Update html report with oval details #2055
Conversation
With this update it is clearer when a test fails due to a few objects from many collected Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
There was a problem hiding this comment.
Hi, thank you very much for opening this PR.
While adding this can be useful in many situations, it's affected by the problem that our details section doesn't show the full structure of the OVAL tree. Specifically, if you add these results, the users don't know if there is a state element in the given test and what this state contains. That can cause confusion. I'm not sure how to address this, though.
I suggest at least to be more clear by renaming the Result column to Result of item-state comparison. Hopefully, renaming it will slightly lower the confusion.
Also on a related note I would like to invite you to check the https://github.com/OpenSCAP/openscap-report project which aims to generate a more verbose and modern HTML report than what we have here.
Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
|
I like the idea of showing which collected object does not meet the object state. However, this list could be infinitely long. How about showing only the first failed test object to avoid a huge HTML report? |
This only introduce a new column on the existing items list. Which is actually limited to a max of 100 items |
|
/packit build |
With this update it is clearer when a test fails due to a few objects from many collected
Attaching some examples to show the suggested change in action, and how can it be useful:
Note:
If there is a cleaner way and it is preferable let me know. I'm not quite familiarized with xsl